Skip to content

Commit ebbc874

Browse files
authored
ci : update windows runner to windows-2022 (#3242)
* ci : update windows runner to windows-2022 This commit changes the windows-2019 runner to windows-2022. The motiation for this is that the windows-2019 runner is scheduled for deprection and will be removed 2025-06-30. There are currently "burnout" periods that started 2025-06-01 and during these times jobs with windows-2019 will fail which has happened lately on our CI. Refs: actions/runner-images#12045
1 parent 2679bec commit ebbc874

File tree

1 file changed

+25
-17
lines changed

1 file changed

+25
-17
lines changed

.github/workflows/build.yml

Lines changed: 25 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -761,14 +761,15 @@ jobs:
761761
windows-cublas:
762762
if: ${{ github.event_name == 'push' || github.event_name == 'pull_request' ||
763763
github.event.inputs.run_type == 'full-ci' }}
764-
runs-on: windows-2019
764+
runs-on: windows-2022
765765
strategy:
766+
fail-fast: false
766767
matrix:
767768
build: [Release]
768769
arch: [x64]
769770
cublas: [ON]
770771
sdl2: [ON]
771-
cuda-toolkit: [12.2.0, 11.8.0]
772+
cuda-toolkit: [12.4.0, 11.8.0]
772773
include:
773774
- arch: x64
774775
sdl2: ON
@@ -836,31 +837,31 @@ jobs:
836837
xcopy "$CUDA_TOOLKIT_DIR\visual_studio_integration-windows-x86_64-${VS_VER}-archive\*" "$CUDA_TOOLKIT_DIR" /E /I /H /Y
837838
838839
# Visual Studio integration
839-
xcopy "$CUDA_TOOLKIT_DIR\visual_studio_integration-windows-x86_64-${VS_VER}-archive\visual_studio_integration\MSBuildExtensions\*" "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\BuildCustomizations" /E /I /H /Y
840+
xcopy "$CUDA_TOOLKIT_DIR\visual_studio_integration-windows-x86_64-${VS_VER}-archive\visual_studio_integration\MSBuildExtensions\*" "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\BuildCustomizations" /E /I /H /Y
840841
841842
# Set environment variables
842843
echo "$CUDA_TOOLKIT_DIR\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
843844
echo "$CUDA_TOOLKIT_DIR\libnvvp" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
844845
echo "CUDA_PATH=$CUDA_TOOLKIT_DIR" | Out-File -FilePath $env:GITHUB_ENV -Append -Encoding utf8
845846
echo "CUDA_PATH_V11_8=$CUDA_TOOLKIT_DIR" | Out-File -FilePath $env:GITHUB_ENV -Append -Encoding utf8
846847
847-
- name: Install Cuda Toolkit 12.2.0
848-
if: ${{ matrix.cuda-toolkit == '12.2.0' }}
848+
- name: Install Cuda Toolkit 12.4.0
849+
if: ${{ matrix.cuda-toolkit == '12.4.0' }}
849850
run: |
850851
$CUDA_VERSION = ${{ matrix.cuda-toolkit }}
851852
$CUDA_TOOLKIT_DIR = "C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v$CUDA_VERSION"
852853
$CUDA_DOWNLOAD = "https://developer.download.nvidia.com/compute/cuda/redist"
853854
854855
# Components versions
855-
$CUDART_VER = "12.2.140"
856-
$NVCC_VER = "12.2.140"
857-
$NVRTC_VER = "12.2.140"
858-
$CUBLAS_VER = "12.2.5.6"
859-
$NVTX_VER = "12.2.140"
860-
$PROFILER_VER = "12.2.140"
861-
$VS_VER = "12.2.140"
862-
$NVPROF_VER = "12.2.142"
863-
$CCCL_VER = "12.2.140"
856+
$CUDART_VER = "12.4.127"
857+
$NVCC_VER = "12.4.131"
858+
$NVRTC_VER = "12.4.127"
859+
$CUBLAS_VER = "12.4.5.8"
860+
$NVTX_VER = "12.4.127"
861+
$PROFILER_VER = "12.4.127"
862+
$VS_VER = "12.4.127"
863+
$NVPROF_VER = "12.4.128"
864+
$CCCL_VER = "12.4.127"
864865
865866
# Create the directory where the CUDA Toolkit will be installed
866867
mkdir -p $CUDA_TOOLKIT_DIR
@@ -894,7 +895,7 @@ jobs:
894895
xcopy "$CUDA_TOOLKIT_DIR\visual_studio_integration-windows-x86_64-${VS_VER}-archive\*" "$CUDA_TOOLKIT_DIR" /E /I /H /Y
895896
896897
# Visual Studio integration
897-
xcopy "$CUDA_TOOLKIT_DIR\visual_studio_integration-windows-x86_64-${VS_VER}-archive\visual_studio_integration\MSBuildExtensions\*" "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\BuildCustomizations" /E /I /H /Y
898+
xcopy "$CUDA_TOOLKIT_DIR\visual_studio_integration-windows-x86_64-${VS_VER}-archive\visual_studio_integration\MSBuildExtensions\*" "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\BuildCustomizations" /E /I /H /Y
898899
899900
# Set environment variables
900901
echo "$CUDA_TOOLKIT_DIR\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
@@ -922,14 +923,21 @@ jobs:
922923
- name: Build Project
923924
shell: cmd
924925
run: |
925-
call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
926+
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
926927
cmake --version
927928
where cmake
929+
if "${{ matrix.cuda-toolkit }}" == "11.8.0" (
930+
set CUDA_FLAGS=-allow-unsupported-compiler -D_ALLOW_COMPILER_AND_STL_VERSION_MISMATCH -D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR
931+
) else (
932+
set CUDA_FLAGS=
933+
)
928934
cmake -S . -B build -G "Ninja Multi-Config" ^
929935
-DCMAKE_BUILD_TYPE=${{ matrix.build }} ^
930936
-DGGML_CUDA=${{ matrix.cublas }} ^
931937
-DWHISPER_SDL2=${{ matrix.sdl2 }} ^
932-
-DSDL2_DIR="%SDL2_DIR%"
938+
-DSDL2_DIR="%SDL2_DIR%" ^
939+
-DCMAKE_POLICY_VERSION_MINIMUM=3.5 ^
940+
-DCMAKE_CUDA_FLAGS="%CUDA_FLAGS%"
933941
set /A NINJA_JOBS=%NUMBER_OF_PROCESSORS%-1
934942
cmake --build build --config ${{ matrix.build }} -j %NUMBER_OF_PROCESSORS%
935943

0 commit comments

Comments
 (0)