-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Quantum: Add OpenSSL signature models #19705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nicolaswill
merged 27 commits into
github:main
from
bdrodes:pawel_signatures_conversion
Jun 18, 2025
Merged
Changes from 24 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
39583ab
Crypto: Update KnownAlgoirthmConstants to make a distinction between …
bdrodes 952bc26
Crypto: Added Signature algorithm instance and consumer
bdrodes 33e239d
Crypto: Collapse initializer qll's into operations.
bdrodes f952f90
Crypto: Update CtxFlow to flow from any "source ctx" which is any ctx…
bdrodes 98aae6a
Crypto: Add EVP key gen and signature operation (work in progress). A…
bdrodes 4f2045b
Crypto: CtxFlow now uses an interface for additional steps. Add CTX s…
bdrodes 729467c
Crypto: Separate out CTX parameter initialization, and add additional…
bdrodes 7d47994
Crypto: Nop out signature operations for now until complete. Minor mo…
bdrodes d3cff2d
Crypto: Add support to trace keys, add support to find prior key gen …
bdrodes 8f25380
Crypto: Consolidate tests to use node, edges, and properties.
bdrodes 20e2c7c
Crypto: Overhaul/refactor of EVPInitialzers. Update cipher operation …
bdrodes eb20955
Crypto: Further simplify test caes to only use edges/nodes/properties…
bdrodes cf2f0f1
Crypto: Initial model of signatures. Still incomplete for verificatio…
bdrodes fb495bf
Crypto: Update expected files. There are failures, but accepting them…
bdrodes 1882db7
Crypto: EVP Signature Operation cleanup.
bdrodes db0bc47
Merge branch 'main' into pawel_signatures_conversion
nicolaswill f975428
Merge branch 'main' into pawel_signatures_conversion
nicolaswill 45fa2c9
Crypto: Code review cleanup.
bdrodes 90e480b
Merge branch 'pawel_signatures_conversion' of https://github.com/bdro…
bdrodes 790a607
Crypto: Acronym change from OpenSSL to OpenSsl, AVC to Avc and EVP to…
bdrodes 7c18686
Crypto: Further ql-for-ql alert alert fixes.
bdrodes 6c9c969
Crypto: Remove dead comments
bdrodes 2b6a832
Crypto: Update JCA model to account for Model.qll changes.
bdrodes ac35634
Merge branch 'openssl_acronym_normalization' into pawel_signatures_co…
bdrodes f2f97c9
Crypto: QL docs fix.
bdrodes a81fffc
Crypto: Fix redundant override issue.
bdrodes b2765a2
Merge branch 'main' into pawel_signatures_conversion
bdrodes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant. SHA_ cannot match SHA1 or SHA3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
_
in matches means match one character, not any character (+ vs *), so it isn't redundant. The issue was I accidentally used the '+' syntax previously.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Four years of writing CodeQL, and I just learned that now...
Anyway, isn't
_%
redundant then? Just%
should do the same thing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I basically didn't want to match just "sha" and call it sha2. I wrote this awhile back so there is probably a better way, but basically it would not be correct to just use % because of that.