Skip to content

KeyValueInputs - Documentation #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Jul 1, 2025
Merged

KeyValueInputs - Documentation #2941

merged 46 commits into from
Jul 1, 2025

Conversation

majedelass
Copy link
Contributor

@majedelass majedelass commented Jun 9, 2025 •
edited by KristinLBradley
Loading

📌 Summary

If merged, this PR will add the documentation for our Form::KeyValueInputs component.

🛠️ Detailed description

The new documentation lives in Forms > Key Value Inputs
https://hds-website-git-key-value-inputs-doc-hashicorp.vercel.app/components/form/key-value-inputs

Related PR: #2911

🔗 External links

Jira ticket: HDS-4874

@majedelass majedelass requested review from a team as code owners June 9, 2025 18:23
@vercel Vercel
Copy link

vercel bot commented Jun 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jul 1, 2025 3:55pm
hds-website ✅ Ready (Inspect) Visit Preview Jul 1, 2025 3:55pm

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Jun 9, 2025
heatherlarsen
heatherlarsen reviewed Jun 9, 2025
View reviewed changes
Copy link
Contributor

@heatherlarsen heatherlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left mostly nit pick feedback

@majedelass majedelass requested a review from heatherlarsen June 10, 2025 17:44
heatherlarsen
heatherlarsen reviewed Jun 10, 2025
View reviewed changes
Copy link
Contributor

@heatherlarsen heatherlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few more minor nitpicks. Sorry!

@majedelass majedelass requested a review from heatherlarsen June 10, 2025 19:58
jorytindall
jorytindall reviewed Jun 10, 2025
View reviewed changes
heatherlarsen
heatherlarsen previously approved these changes Jun 11, 2025
View reviewed changes
LilithJames-HDS
LilithJames-HDS previously approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@LilithJames-HDS LilithJames-HDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All super nitpicky comments that you can ignore if you disagree with. This is really great!

@majedelass @LilithJames-HDS
Apply suggestions from code review
ad2e27e 
Co-authored-by: LilithJames-HDS <lilith.james@hashicorp.com>
LilithJames-HDS
LilithJames-HDS previously approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@LilithJames-HDS LilithJames-HDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

dchyun
dchyun reviewed Jul 1, 2025
View reviewed changes
@didoo @dchyun
Apply suggestions from code review
622d021 
Co-authored-by: Dylan Hyun <dylan.hyun@hashicorp.com>
@didoo didoo changed the base branch from main to docs/4.21 July 1, 2025 16:19
@majedelass majedelass merged commit 3e05a0e into docs/4.21 Jul 1, 2025
11 checks passed
@majedelass majedelass deleted the key-value-inputs-doc branch July 1, 2025 16:40
@dchyun dchyun mentioned this pull request Jul 1, 2025
Merged
3 tasks
dchyun added a commit that referenced this pull request Jul 1, 2025
@majedelass @heatherlarsen
@shleewhite @dchyun @didoo @KristinLBradley @jorytindall @LilithJames-HDS
KeyValueInputs - Documentation (#2941)
3c57024 
Co-authored-by: Heather Larsen <hlarsen@hashicorp.com>
Co-authored-by: Lee White <lee.white@hashicorp.com>
Co-authored-by: shleewhite <lee.white@hahicorp.com>
Co-authored-by: Dylan Hyun <dylan.hyun@hashicorp.com>
Co-authored-by: Cristiano Rastelli <public@didoo.net>
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
Co-authored-by: Kristin Bradley <kristin.bradley@hashicorp.com>
Co-authored-by: Jory Tindall <jory.tindall@hashicorp.com>
Co-authored-by: LilithJames-HDS <lilith.james@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didoo didoo didoo left review comments

@shleewhite shleewhite shleewhite left review comments

@andgen404 andgen404 andgen404 left review comments

@jorytindall jorytindall jorytindall approved these changes

@dchyun dchyun dchyun approved these changes

@LilithJames-HDS LilithJames-HDS LilithJames-HDS approved these changes

@heatherlarsen heatherlarsen Awaiting requested review from heatherlarsen

@KristinLBradley KristinLBradley Awaiting requested review from KristinLBradley

@alex-ju alex-ju Awaiting requested review from alex-ju

Assignees
No one assigned
Labels
docs-website Content updates to the documentation website
Projects
None yet
Milestone
design-system-components@4.21.0
Development

Successfully merging this pull request may close these issues.