-
Notifications
You must be signed in to change notification settings - Fork 49
Update AppHeader
docs with Application Title content
#2968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…dding instead to support variable length string content
…sktop to the showcase, along with examples of child components
… default and simplified logic
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there may be an issue in the Component API definitions
website/docs/components/app-header/partials/code/component-api.md
Outdated
Show resolved
Hide resolved
website/docs/components/app-header/partials/code/component-api.md
Outdated
Show resolved
Hide resolved
website/docs/components/app-header/partials/code/component-api.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 👍
📌 Summary
This PR updates the documentation of the
AppHeader
with content detailing the properties and arguments pertaining to adding an application title, including:@text
and@isIconOnly
propertiesaria-label
within the home link@ariaLabel
property from the component API.🔗 External links
Jira ticket: HDS-4918
Figma file
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.