Skip to content

Update Grid docs to show example of wrapping behavior to clarify for … #2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KristinLBradley
Copy link
Contributor

@KristinLBradley KristinLBradley commented Jun 23, 2025

UPDATE: Opened a new ticket to explore solution to consumer's actual layout issue: https://hashicorp.atlassian.net/browse/HDS-5013

(Will probably close or amend this PR accordingly)


πŸ“Œ Summary

If merged, this PR will update Layout::Grid docs to include an example of wrapping behavior to clarify the behavior for consumers.

This arose from a consumer question shared by @shleewhite

Preview: https://hds-website-git-kristin-update-grid-docs-to-sh-cb97ad-hashicorp.vercel.app/layouts/grid#card-layouts


πŸ‘€ Component checklist

  • [ ] Percy was checked for any visual regression
  • [ ] A changelog entry was added via Changesets if needed (see templates here)

πŸ’¬ Please consider using conventional comments when reviewing this PR.

πŸ“‹ PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

Copy link

vercel bot commented Jun 23, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
hds-showcase βœ… Ready (Inspect) Visit Preview Jun 23, 2025 8:04pm
hds-website βœ… Ready (Inspect) Visit Preview Jun 23, 2025 8:04pm

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Jun 23, 2025
@KristinLBradley KristinLBradley marked this pull request as ready for review June 23, 2025 20:50
@KristinLBradley KristinLBradley requested review from a team as code owners June 23, 2025 20:50
@KristinLBradley KristinLBradley marked this pull request as draft June 23, 2025 21:09
@didoo
Copy link
Contributor

didoo commented Jun 24, 2025

This arose from a consumer question shared by @shleewhite

Was it a private DM or a publick Slack message? In that case, would it be possible to link the original request/conversation for future reference?

@KristinLBradley
Copy link
Contributor Author

KristinLBradley commented Jun 24, 2025

This arose from a consumer question shared by @shleewhite

Was it a private DM or a publick Slack message? In that case, would it be possible to link the original request/conversation for future reference?

@didoo

@shleewhite messaged me on Slack about it. I think a consumer had slacked her first directly.

I've since opened a new ticket to examine a solution to what seems to be the consumer's real issue so I will likely close the PR.

@shleewhite
Copy link
Contributor

@didoo @KristinLBradley it was Anna, our intern, who brought up the concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants