-
Notifications
You must be signed in to change notification settings - Fork 49
KeyValueInputs
- Showcase
#2973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
61d2b67
to
3e927db
Compare
f218096
to
b7b5c47
Compare
3e927db
to
fb29869
Compare
b7b5c47
to
18f8ded
Compare
9ad8d4c
to
18f8ded
Compare
18f8ded
to
5d963f5
Compare
5d963f5
to
4935322
Compare
73d229a
to
5b4a7cf
Compare
dfa7392
to
d1fbd27
Compare
The new demo is a great walkthrough of the expected pattern! I went through all the listed steps, and some of my own attempting to break it and it is working smoothly for all of those cases. My one suggestion is on the expected behavior for how the delete button acts on the first row when no other rows are present. In the current demo:
Based on the design guidance on delete behavior the expected interaction is slightly different.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick initial review, will circle back to look more thoroughly after the long weekend.
π Summary
This is a follow-up of #2911, where we add the showcase pages for the
KeyValueInput
and re-create functional demos of UX flows that we've spotted in production.π οΈ Detailed description
In this PR I have:
KeyValueInputs
- Component implementationΒ #2911 (branchhds-4903/key-value-component
)KeyValueInputs
within an<Hds::Form>
Previews:
π External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-5069
π Component checklist
π¬ Please consider using conventional comments when reviewing this PR.
π PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.