Skip to content

Update roc bert docs #38835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jun 17, 2025
Merged

Conversation

SohamPrabhu
Copy link
Contributor

@SohamPrabhu SohamPrabhu commented Jun 16, 2025

What does this PR do?

This PR updates the model card according to the changes needed on the pull request.

#36979 (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SohamPrabhu
Copy link
Contributor Author

Btw I was not sure what to put for some of the links for for the model.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You don't need to make any changes to the moonshine.md file :)

@SohamPrabhu
Copy link
Contributor Author

@stevhliu Just fixed the Documentation.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a couple more things. Remember to revert your changes to the Moonshine card

> [!TIP]
> This model was contributed by [weiweishi](https://huggingface.co/weiweishi).
>
> Click on the RoCBert models in the right sidebar for more examples of how to apply RoCBert to different Chinese language tasks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Click on the RoCBert models in the right sidebar for more examples of how to apply RoCBert to different Chinese language tasks.
> Click on the RoCBert models in the right sidebar for more examples of how to apply RoCBert to different Chinese language tasks.
The example below demonstrates how to predict the [MASK] token with [`Pipeline`], [`AutoModel`], and from the command line.

@@ -14,35 +14,76 @@ rendered properly in your Markdown viewer.

-->

# Moonshine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert all the changes in this doc as its not needed

@SohamPrabhu
Copy link
Contributor Author

@stevhliu I changed it according to your commits, However I don't understand what I don't have in the moonshine documentation.

@stevhliu
Copy link
Member

I think you just need to rebase your branch to get the latest changes from the Moonshine docs

Your Name and others added 7 commits June 17, 2025 12:46
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@SohamPrabhu SohamPrabhu force-pushed the update-roc_ber-docs branch from 27f9063 to 0c02798 Compare June 17, 2025 16:49
@SohamPrabhu
Copy link
Contributor Author

@stevhliu Thank you for your help I think I finally got it.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu merged commit a396f43 into huggingface:main Jun 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants