Skip to content

Update bamba model card #38853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 18, 2025
Merged

Conversation

druvdub
Copy link
Contributor

@druvdub druvdub commented Jun 17, 2025

What does this PR do?

Updates bamba model card for #36979

Before submitting

Who can review?

@stevhliu

@druvdub
Copy link
Contributor Author

druvdub commented Jun 17, 2025

Just a couple questions here as well. So far, I have basically mapped the content from previous format to current one + added some information about quantization.

Is there a way to potentially know if a model can be used with the pipeline API or the cli command? Or can I just expect that a model might support all 3 methods or whatever it has in its documentation?

I tried running the Bamba model using pipeline but kept on getting memory issues, so I am not sure if it can be run using the pipeline API or not.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🤗

@stevhliu
Copy link
Member

Is there a way to potentially know if a model can be used with the pipeline API or the cli command? Or can I just expect that a model might support all 3 methods or whatever it has in its documentation?

In general, I think most models should work with the Pipeline API. For example, there is a BambaForCausalLM class and the TextGenerationPipeline says it supports any models with the ModelForCausalLM head.

For the cli command, it only takes text inputs so it doesn't support audio, vision, or multimodal inputs.

druvdub and others added 11 commits June 17, 2025 22:08
Bamba paragraph

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Bamba collection url

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Update Padding-Free Training to Notes heading

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
update examples

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Update additional info

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
consistent casing

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
simplify sentences

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@druvdub
Copy link
Contributor Author

druvdub commented Jun 18, 2025

@stevhliu This should be sorted now hopefully, other than just clarifying transformers vs transformers-cli

Also, could you please clarify what this CI check refers to

Repository-wide checks:
    - checking all models are included.
    - checking all models are public.
    - checking all models have tests.
    - checking all objects have documentation.
Traceback (most recent call last):
  File "/root/transformers/utils/check_repo.py", line 1269, in <module>
    check_repo_quality()
  File "/root/transformers/utils/check_repo.py", line 1253, in check_repo_quality
    check_all_objects_are_documented()
  File "/root/transformers/utils/check_repo.py", line 1130, in check_all_objects_are_documented
    raise Exception(
Exception: The following objects are in the public init, but not in the docs:
 - BambaModel

Exited with code exit status 1

Is this because its looking for the mention of BambaModel which usually comes under BambaConfig?

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work on this!

I'm not too sure about the CI message. Can you try adding the following to the doc after ## BambaConfig?

## BambaModel

[[autodoc]] BambaModel

druvdub and others added 2 commits June 18, 2025 21:08
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@druvdub
Copy link
Contributor Author

druvdub commented Jun 18, 2025

Thanks for all your work on this!

I'm not too sure about the CI message. Can you try adding the following to the doc after ## BambaConfig?

## BambaModel

[[autodoc]] BambaModel

Ah, that fixed the issue. The class had an auto_docstring annotation. Should be fine now! 🤗

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and big thanks! 🤗

@stevhliu stevhliu merged commit 458e0b3 into huggingface:main Jun 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants