-
Notifications
You must be signed in to change notification settings - Fork 29.4k
Update bamba model card #38853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bamba model card #38853
Conversation
Just a couple questions here as well. So far, I have basically mapped the content from previous format to current one + added some information about quantization. Is there a way to potentially know if a model can be used with the I tried running the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🤗
In general, I think most models should work with the For the |
Bamba paragraph Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Bamba collection url Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Update Padding-Free Training to Notes heading Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
update examples Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Update additional info Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
consistent casing Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
simplify sentences Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
update cli id
@stevhliu This should be sorted now hopefully, other than just clarifying Also, could you please clarify what this CI check refers to Repository-wide checks:
- checking all models are included.
- checking all models are public.
- checking all models have tests.
- checking all objects have documentation.
Traceback (most recent call last):
File "/root/transformers/utils/check_repo.py", line 1269, in <module>
check_repo_quality()
File "/root/transformers/utils/check_repo.py", line 1253, in check_repo_quality
check_all_objects_are_documented()
File "/root/transformers/utils/check_repo.py", line 1130, in check_all_objects_are_documented
raise Exception(
Exception: The following objects are in the public init, but not in the docs:
- BambaModel
Exited with code exit status 1 Is this because its looking for the mention of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your work on this!
I'm not too sure about the CI message. Can you try adding the following to the doc after ## BambaConfig
?
## BambaModel
[[autodoc]] BambaModel
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Ah, that fixed the issue. The class had an |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and big thanks! 🤗
What does this PR do?
Updates
bamba
model card for #36979Before submitting
Pull Request section?
to it if that's the case. [Community contributions] Model cards #36979
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@stevhliu