Clarify per_device_train_batch_size scaling in TrainingArguments (#38… #38857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunMarc
reviewed
Jun 17, 2025
|
Usually we call it the global batch size |
Shohail-Ismail
force-pushed
the
fix-per-device-batchsize-doc
branch
2 times, most recently
from
4e383cc to
d085301
Compare
Shohail-Ismail
force-pushed
the
fix-per-device-batchsize-doc
branch
from
d085301 to
3570b79
Compare
|
Ready for final review and merge. Thanks! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR clarifies in the
TrainingArgumentsdocstring thatper_device_train_batch_sizeis multiplied by the number of devices when training on multiple GPUs or with distributed training.
Closes #38484
Before submitting
Who can review?