chore(build): Make empty client and server modules private #2291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADSteele916
force-pushed
the
remove-empty-exports
branch
from
292dec1 to
7cffad1
Compare
|
What branch should I target? I initially tried |
ADSteele916
force-pushed
the
remove-empty-exports
branch
2 times, most recently
from
11ebca7 to
292dec1
Compare
|
Sounds reasonable to me. It looks needed to be waited until the next release with breaking changes. |
LucioFranco
approved these changes
Jun 16, 2025
tottoto
approved these changes
Jun 18, 2025
JASON27333
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
tonic_buildexports theclientandservermodules, both of which contain only private items. Exporting these modules only serves to clutter up the crate's docs. This PR makes the two modules private.