Skip to content

Update code files to match standard #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update code files to match standard #5

wants to merge 1 commit into from

Conversation

isc-ddo
Copy link

@isc-ddo isc-ddo commented Dec 9, 2019

No description provided.

@isc-ddo
Copy link
Author

isc-ddo commented Dec 18, 2019

Hi @lexiISC, please review and merge the pull request.

lexiISC
lexiISC reviewed Dec 18, 2019
View reviewed changes
Copy link
Collaborator

@lexiISC lexiISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is our standard on embedded SQL (e.g., &sql(select count(%ID) into :count from DataMining.IrisDataset))
It seems to me that we should check SQLCODE after every single embedded SQL statement.

@isc-ddo
Copy link
Author

isc-ddo commented Dec 18, 2019

On the list of sample code checklist that I need to update does not mention embedded SQL so I am not sure about that. If you could tell me how to check the SQLCODE after every single embedded SQL statement, I could integrate it into my pull request. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexiISC lexiISC lexiISC left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isc-ddo @lexiISC