Skip to content

bug: radio-group-wrapper breaks removing options with react #30359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
postmann opened this issue Apr 14, 2025 · 1 comment
Open
3 tasks done

bug: radio-group-wrapper breaks removing options with react #30359

postmann opened this issue Apr 14, 2025 · 1 comment
Labels
package: react @ionic/react package type: bug a confirmed bug report

Comments

@postmann
Copy link

postmann commented Apr 14, 2025

Prerequisites

Ionic Framework Version

v8.x

Current Behavior

The radio-group-wrapper which was introduced in core/src/components/radio-group/radio-group.tsx for solving #30222 causes React to crash when options are added/removed dynamically like in the typeahead selection example from the docs.

Expected Behavior

Ionic should not cause React to crash when radio options are added/removed dynamically.

Steps to Reproduce

  1. Create a React-based ionic app
  2. Add a modal with radio group and typeahead functionality (similar to the one from the docs, but should also work without a modal around the radio group
  3. Run the app, type something into the searchbar for filtering the radio items

Code Reproduction URL

https://stackblitz.com/edit/4cdat5jx

Ionic Info

Ionic:

   Ionic CLI       : 7.2.1 (/home/reuter/.nvm/versions/node/v20.18.0/lib/node_modules/@ionic/cli)
   Ionic Framework : @ionic/react 8.5.4

Capacitor:

   Capacitor CLI      : 7.2.0
   @capacitor/android : 7.2.0
   @capacitor/core    : 7.2.0
   @capacitor/ios     : 7.2.0

Utility:

   cordova-res : not installed globally
   native-run  : 2.0.1

System:

   NodeJS : v20.18.0 (/home/reuter/.nvm/versions/node/v20.18.0/bin/node)
   npm    : 10.8.2
   OS     : Linux 5.15

Additional Information

Workaround: revert Ionic version to 8.4

@ionitron-bot ionitron-bot bot added the triage label Apr 14, 2025
@tdeckard2000
Copy link

I am experiencing the same problem.

I was also seeing an issue with the @ion-modal (ex. @ion-modal-did-present) lifecycle hooks not firing. Installing "@ionic/vue@8.4.0" resolved both issues.

@brandyscarney brandyscarney added package: react @ionic/react package type: bug a confirmed bug report labels Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

3 participants