Skip to content

fix(item-sliding): check for side attribute to avoid an undefined value #29845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Sep 6, 2024

Issue number: resolves #29499


What is the current behavior?

Using the bundled version of Ionic results in an error Uncaught (in promise) Error: "undefined" is not a valid value for [side]. Use "start" or "end" instead. with <ion-item-sliding>.

Reproduction 1:

It is also reproducible in an Ionic Angular app when installed via npm.

Reproduction 2:

What is the new behavior?

Check for the side attribute to avoid side being undefined.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 8.6.1-dev.11749562115.1e681558

Test PR: #30469

The tests must be merged separately, after this is released, in order to use the fix from the CDN.

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2025 1:54pm

@github-actions github-actions bot added the package: core @ionic/core package label Sep 6, 2024
@thetaPC
Copy link
Contributor

thetaPC commented May 23, 2025

@brandyscarney what's the status of this PR?

@brandyscarney
Copy link
Member Author

@thetaPC The fix works but I wanted to find a way to add a test for it but haven't had time to look into it.

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney added this pull request to the merge queue Jun 10, 2025
Merged via the queue into main with commit c38aa07 Jun 10, 2025
56 of 93 checks passed
@brandyscarney brandyscarney deleted the ROU-11160 branch June 10, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ion-item-sliding update error
4 participants