feat(ion-datetime): add hidden-days when theme:ionic #30205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is true; - change datetime component to use this attribute when in theme: ionic; - document changes;
JoaoFerreira-FrontEnd
added
type: feature request
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
reviewed
Feb 21, 2025
| days = [{ day: null, dayOfWeek: null }, ...days]; | ||
| } else { | ||
| for (let i = 0; i <= offset; i++) { | ||
| days = [{ day: null, dayOfWeek: null, hiddenDay:true }, ...days]; |
There was a problem hiding this comment.
Wouldn't hiddenDay be false?
There was a problem hiding this comment.
yeap, I'll fix it
Comment on lines
+2244
to
+2262
| if(hiddenDay && day !== null && day > 20) { | ||
| // Leading with the hidden day from the previous month | ||
| // if its a hidden day and is higher than '20' (last week even in feb) | ||
| if(month === 1) { | ||
| _year = year - 1; | ||
| _month = 12; | ||
| }else{ | ||
| _month = month-1; | ||
| } | ||
| } else if(hiddenDay && day !== null && day < 15) { | ||
| // Leading with the hidden day from the next month | ||
| // if its a hidden day and is lower than '15' (first two weeks) | ||
| if(month === 12) { | ||
| _year = year + 1; | ||
| _month = 1; | ||
| } else { | ||
| _month = month + 1; | ||
| } | ||
| } |
There was a problem hiding this comment.
Wouldn't this calculation be done through getDaysOfMonth?
There was a problem hiding this comment.
getDaysOfMonth doesn't have value of month or year
|
@JoaoFerreira-FrontEnd what's the status of this PR? Can we close it? |
| days = [{ day: null, dayOfWeek: null }, ...days]; | ||
| } else { | ||
| for (let i = 0; i <= offset; i++) { | ||
| days = [{ day: null, dayOfWeek: null, hiddenDay:true }, ...days]; |
There was a problem hiding this comment.
yeap, I'll fix it
Comment on lines
+2244
to
+2262
| if(hiddenDay && day !== null && day > 20) { | ||
| // Leading with the hidden day from the previous month | ||
| // if its a hidden day and is higher than '20' (last week even in feb) | ||
| if(month === 1) { | ||
| _year = year - 1; | ||
| _month = 12; | ||
| }else{ | ||
| _month = month-1; | ||
| } | ||
| } else if(hiddenDay && day !== null && day < 15) { | ||
| // Leading with the hidden day from the next month | ||
| // if its a hidden day and is lower than '15' (first two weeks) | ||
| if(month === 12) { | ||
| _year = year + 1; | ||
| _month = 1; | ||
| } else { | ||
| _month = month + 1; | ||
| } | ||
| } |
There was a problem hiding this comment.
getDaysOfMonth doesn't have value of month or year
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information