feat(api): support quotes to amount #265
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds support for fetching quotes by specifying the desired
toAmount
instead offromAmount
.this is achieved by:
QuoteRequest
that allows eitherfromAmount
ortoAmount
(but not both).getQuote
method insrc/services/api.ts
to:fromAmount
ortoAmount
is provided, and not both./quote/toAmount
endpoint whentoAmount
is specified, or the existing/quote
endpoint whenfromAmount
is used.src/services/api.unit.spec.ts
to cover the new validation logic fortoAmount
and the case where bothfromAmount
andtoAmount
are erroneously provided.this aligns the sdk with the
v1/quote/toAmount
api endpoint (docs: https://apidocs.li.fi/reference/get_v1-quote-toamount), providing users with more flexibility when requesting quotes.this is my first contribution. any feedback is welcome.