[CIR] Clean up enum attributes #1678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
xlauko
force-pushed
the
users/xlauko/cir-enum-attrs
branch
from
df06292 to
0989f80
Compare
Create CIR specific EnumAttr bases and prefix enum attributes with `CIR_`
xlauko
force-pushed
the
users/xlauko/cir-enum-attrs
branch
from
0989f80 to
8bfa60d
Compare
bcardosolopes
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create CIR specific EnumAttr bases and prefix enum attributes with
CIR_that automatically puts enum tocirnamespaceRemoves unnecessary enum case definitions
Unifies naming of enum values to use capitals consistently and make enumerations to start from 0
Remove now unnecessary printers/parsers that gets to be generated automatically