[CIR][CIRGen][Builtin][X86] Lower __rdtscp #1686
Open
+53
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
approved these changes
Jun 18, 2025
| @@ -144,5 +144,26 @@ mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned BuiltinID, | |||
| getLoc(E->getExprLoc()), builder.getStringAttr("x86.rdtsc"), intTy) | |||
| .getResult(); | |||
| } | |||
| case X86::BI__builtin_ia32_rdtscp: { | |||
|
|
|||
There was a problem hiding this comment.
Not for this PR, but something to note here: in OG CGM.getIntrinsic seems to be able to figure out the type of the intrinsic, we should do the same in CIR to make writing these easier:
case X86::BI__builtin_ia32_rdtscp: {
Value *Call = Builder.CreateCall(CGM.getIntrinsic(Intrinsic::x86_rdtscp));
Builder.CreateDefaultAlignedStore(Builder.CreateExtractValue(Call, 1),
Ops[0]);
return Builder.CreateExtractValue(Call, 0);
}
There was a problem hiding this comment.
Thanks for your suggestion, will definitely help as I wanna cover these intrinsics.
|
Good to land once conflict is fixed |
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved rd related intrinsic tests, to a different file similar to
clang/test/CodeGen/X86/rd-builtins.c. Let me know if that's the right call.related: #1404