[CIR] Use ComplexRealOp for RValue __real__ operator
#1689
+45
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC. @andykaylor |
andykaylor
approved these changes
Jun 17, 2025
| // CHECK-AFTER: } | ||
|
|
||
| // LLVM: define dso_local void @extract_real() | ||
| // LLVM: %{{.+}} = load double, ptr @c, align 8 | ||
| // LLVM: %{{.+}} = load i32, ptr @ci, align 4 | ||
| // LLVM: %[[COMPLEX_D:.*]] = load { double, double }, ptr @c, align 8 |
There was a problem hiding this comment.
It's not great that we're loading the whole complex value when we only need one component, but hopefully the optimizer will do something about that. If necessary, we can create a CIR-specific transform.
There was a problem hiding this comment.
Exactly, we can check if it is handled by the optimiser, or we can create our own transform. I will create a PR for __imag__ :D
Yes __real__ c = 10; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
__real__operation to use ComplexRealOp and act directly on the complex value.Ref: llvm/llvm-project#144235 (review)