Skip to content

[Orc] Fix error handling in ORCPlatformSupport::initialize #144637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Orc] Fix error handling in ORCPlatformSupport::initialize #144637

wants to merge 1 commit into from

Conversation

SahilPatidar
Copy link
Contributor

Previously, result was checked before handling the Error returned by callSPSWrapper. If Error was success but result indicated failure, the original Error was silently dropped, triggering an assertion failure for unhandled Error.

This patch ensures the Error is checked and returned before inspecting result, preventing assertion failures.

@SahilPatidar SahilPatidar marked this pull request as ready for review June 18, 2025 05:56
@SahilPatidar SahilPatidar requested a review from lhames June 18, 2025 05:57
lhames
lhames approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@lhames lhames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @SahilPatidar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhames lhames lhames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SahilPatidar @lhames