chore: race snapshot against dialog #598
Closed
+40
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| element: 'Login', | ||
| ref: 'e3', | ||
| }, | ||
| })).toContainTextContent(`"alert" dialog`); |
There was a problem hiding this comment.
Unclear why this test would work. Click will return immediately, snapshot will be empty. Then the dialog will appear.
There was a problem hiding this comment.
It passes because of our 1s wait:
playwright-mcp/src/tools/utils.ts
Line 65 in 137b747
|
Closing as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A dialog that pops up while we're taking a snapshot, or while
context.waitForTimeoutis running, blocks everything, leading to #595.We fix that by wrapping more of our code with
_raceAgainstModalDialogs.Closes #595