java v2: client wrapper instrumentation #7638
Open
+5,338
−1,099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
requested review from
srnagar,
anuchandy,
weidongxu-microsoft,
haolingdong-msft and
XiaofeiCao
as code owners
microsoft-github-policy-service
bot
added
the
emitter:client:java
|
No changes needing a change description found. |
|
You can try these changes here
|
...n/java/com/microsoft/typespec/http/client/generator/core/model/clientmodel/ClientMethod.java
Outdated
Show resolved
Hide resolved
srnagar
reviewed
Jun 18, 2025
...nerator/http-client-generator-clientcore-test/src/main/java/encode/bytes/PropertyClient.java
Outdated
Show resolved
Hide resolved
.../http-client-generator-clientcore-test/src/main/java/authentication/apikey/ApiKeyClient.java
Outdated
Show resolved
Hide resolved
...lient-generator-clientcore-test/src/main/java/authentication/apikey/ApiKeyClientBuilder.java
Outdated
Show resolved
Hide resolved
...com/microsoft/typespec/http/client/generator/core/template/ServiceClientBuilderTemplate.java
Outdated
Show resolved
Hide resolved
...com/microsoft/typespec/http/client/generator/core/template/ServiceClientBuilderTemplate.java
Outdated
Show resolved
Hide resolved
...generator/http-client-generator-clientcore-test/src/main/java/encode/bytes/HeaderClient.java
Outdated
Show resolved
Hide resolved
weidongxu-microsoft
approved these changes
Jun 20, 2025
srnagar
approved these changes
Jul 2, 2025
Comment on lines
+246
to
+254
| HttpInstrumentationOptions localHttpInstrumentationOptions = this.httpInstrumentationOptions == null | ||
| ? new HttpInstrumentationOptions() | ||
| : this.httpInstrumentationOptions; | ||
| SdkInstrumentationOptions sdkInstrumentationOptions | ||
| = new SdkInstrumentationOptions(PROPERTIES.getOrDefault(SDK_NAME, "UnknownName")) | ||
| .setSdkVersion(PROPERTIES.get(SDK_VERSION)) | ||
| .setEndpoint(this.endpoint != null ? this.endpoint : "http://localhost:3000"); | ||
| Instrumentation instrumentation | ||
| = Instrumentation.create(localHttpInstrumentationOptions, sdkInstrumentationOptions); |
There was a problem hiding this comment.
Should we consider moving this to buildInnerClient method? This will help when we introduce a buildAsyncClient in the future and also avoid having to duplicate the endpoint value in both places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding storage changes: Azure/azure-sdk-for-java#45902