policy.defaultValue confusion

[roblourens]

There are some policy.defaultValue which have a different value than the setting's normal default value, like the mcp one:

vscode/src/vs/workbench/contrib/chat/browser/chat.contribution.ts

Lines 240 to 245 in cc47994

	policy: {
	name: 'ChatMCP',
	minimumVersion: '1.99',
	previewFeature: true,
	defaultValue: false
	}

Is that on purpose? Why do we do that?

Also, I think you told me that policy.defaultValue only has an effect for previewFeature: true settings, is that true? Could you add some comments to IPolicy explaining more about how thsi works so we aren't guessing and copy/pasting?

[joshspicer]

That's correct, defaultValue's only usage today is where 'preview' features are controlled.

vscode/src/vs/workbench/services/policies/common/accountPolicyService.ts

Lines 40 to 53 in 62d3667

	if (policy.previewFeature) {
	if (this.chatPreviewFeaturesEnabled) {
	this.policies.delete(key);
	update.push(key);
	continue;
	}
	const defaultValue = policy.defaultValue;
	const updatedValue = defaultValue === undefined ? false : defaultValue;
	if (this.policies.get(key) === updatedValue) {
	continue;
	}
	this.policies.set(key, updatedValue);
	update.push(key);
	}

Added clarification to the interface