Fix xattr copy failures on SELinux systems #6015
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
force-pushed
the
fix-5544-xattr-selinux
branch
from
dd0e37e to
c55e4c0
Compare
How did you test this? |
|
I won't be able to test this as I do not have time to build all the associated components I require. I am simply PR'ing the root cause of the issues I am having, and leaning on this project maintainers to get it merged. |
thaJeztah
reviewed
Jun 13, 2025
solver/llbsolver/ops/exec_binfmt.go
Outdated
| @@ -64,6 +65,15 @@ func (m *staticEmulatorMount) Mount() ([]mount.Mount, func() error, error) { | |||
| if err := copy.Copy(context.TODO(), filepath.Dir(m.path), filepath.Base(m.path), tmpdir, qemuMountName, func(ci *copy.CopyInfo) { | |||
| m := 0555 | |||
| ci.Mode = &m | |||
| ci.XAttrErrorHandler = func(dst, src, xattrKey string, err error) error { | |||
There was a problem hiding this comment.
Looks like there's also functional arguments for this;
buildkit/vendor/github.com/tonistiigi/fsutil/copy/copy.go
Lines 231 to 242 in cd3d075
(but not sure if we can unconditionally ignore all syscall.ENOTSUP errors)
kaovilai
force-pushed
the
fix-5544-xattr-selinux
branch
from
69482ed to
12d70b7
Compare
thaJeztah
reviewed
Jun 13, 2025
kaovilai
force-pushed
the
fix-5544-xattr-selinux
branch
from
7e225a6 to
e65bc1c
Compare
When copying the buildkit-qemu-emulator binary on systems with SELinux enabled, the copy operation fails with "operation not supported" errors when attempting to copy security.selinux xattrs. This change adds an XAttrErrorHandler to the copy.Copy call that ignores ENOTSUP errors, allowing the copy to succeed on SELinux-enabled systems. Fixes moby#5544 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
…ndler function Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
kaovilai
force-pushed
the
fix-5544-xattr-selinux
branch
from
e65bc1c to
b613010
Compare
Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
kaovilai
force-pushed
the
fix-5544-xattr-selinux
branch
from
b613010 to
ca8238c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
When copying the buildkit-qemu-emulator binary on systems with SELinux enabled, the copy operation fails with "operation not supported" errors when attempting to copy security.selinux xattrs.
This PR adds an XAttrErrorHandler to the copy.Copy call that ignores ENOTSUP errors, allowing the copy to succeed on SELinux-enabled systems.
Related Issues
Fixes #5544
Test plan
🤖 Generated with Claude Code