client: allow configuring exporter content store #6045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedevc
commented
Jun 23, 2025
Comment on lines
+205
to
+210
| // TODO: this should be dependent on the exporter id (to allow multiple oci exporters) | ||
| storeName := "export" | ||
| if _, ok := contentStores[storeName]; ok { | ||
| return nil, errors.Errorf("oci store key %q already exists", storeName) | ||
| } | ||
| contentStores[storeName] = store |
There was a problem hiding this comment.
While here, noticed that we create one export key. If a user attempts to use multiple exporters, then we'll accidentally write to whichever the most recent store is.
I've added an explicit error case, and added a note of how this should be improved in the future (but will require a bit of editing on the exporter side as well), so leaving that for future work.
tonistiigi
reviewed
Jun 23, 2025
Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
solveopt-exporter-store
branch
from
ed2ab8a to
dce5cac
Compare
tonistiigi
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just configures
SolveOptso that we can directly pass a containerd store through to an exporter (similar to how we do forOCIStores). No change in the protocol is needed, and all previous calls toSolveshould still be valid.