-
-
Notifications
You must be signed in to change notification settings - Fork 976
fix: prevent stop or pause when drag constraints #2758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: prevent stop or pause when drag constraints #2758
Conversation
it("reset drag constraints (ref-based), when click after dragging", () => { | ||
cy.visit("?test=drag-ref-constraints&elastic=1") | ||
.wait(200) | ||
.get("[data-testid='draggable']") | ||
.trigger("pointerdown", 10, 10) | ||
.wait(200) | ||
.trigger("pointermove", 300, 300, { force: true }) | ||
.wait(200) | ||
.trigger("pointerup", { force: true }) | ||
.trigger("pointerdown", { force: true }) | ||
.trigger("pointerup", { force: true }) | ||
.wait(1000) | ||
.should(($draggable: any) => { | ||
const draggable = $draggable[0] as HTMLDivElement | ||
const { left, top } = draggable.getBoundingClientRect() | ||
|
||
expect(left).to.equal(150) | ||
expect(top).to.equal(150) | ||
}) | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I append E2E test for issue #2697
I'm wondering if it's appropriate to set wait for 1000ms 🤔
Thanks for the PR! Apologises for taking a long time to get around to taking a look. The problem with this approach is we still want this catch functionality to work even if |
Also a failing test:
|
fix #2697
Hello there!
I appreciat your great works 👍
BTW I found some issue at above
as is
2024-08-10.4.11.08.mov
Element pause or stop when click it while dragging
https://github.com/framer/motion/blob/f59114d4d48f4fbd6a611aba62cd9ebab13e06ab/packages/framer-motion/src/gestures/drag/VisualElementDragControls.ts#L101-L103
I think it was problem
to be
2024-08-10.4.13.46.mov
So I prevent stop or pause animation when having
dragConstraints
If you think of any related issues, please share them with me!
Thank you! 😄