Skip to content

feat: add undefinedAsNil option to Encoder #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -122,6 +122,7 @@ console.log(buffer);
| forceFloat32 | boolean | false |
| forceIntegerToFloat | boolean | false |
| ignoreUndefined | boolean | false |
| undefinedAsNil | boolean | true |

### `decode(buffer: ArrayLike<number> | BufferSource, options?: DecoderOptions): unknown`

15 changes: 14 additions & 1 deletion src/Encoder.ts
Original file line number Diff line number Diff line change
@@ -61,6 +61,15 @@ export type EncoderOptions<ContextType = undefined> = Partial<
*/
ignoreUndefined: boolean;

/**
* If `true`, an object property with `undefined` value are encoded as `nil`, same as null.
* e.g. `{ foo: undefined }` will be encoded as `{ foo: nil }`.
* This flag has no effect if `ignoreUndefined` is `true`.
*
* Defaults to `true`.
*/
undefinedAsNil: boolean;

/**
* If `true`, integer numbers are encoded as floating point numbers,
* with the `forceFloat32` option taken into account.
@@ -82,6 +91,7 @@ export class Encoder<ContextType = undefined> {
private readonly forceFloat32: boolean;
private readonly ignoreUndefined: boolean;
private readonly forceIntegerToFloat: boolean;
private readonly undefinedAsNil: boolean;

private pos: number;
private view: DataView;
@@ -99,6 +109,7 @@ export class Encoder<ContextType = undefined> {
this.sortKeys = options?.sortKeys ?? false;
this.forceFloat32 = options?.forceFloat32 ?? false;
this.ignoreUndefined = options?.ignoreUndefined ?? false;
this.undefinedAsNil = options?.undefinedAsNil ?? true;
this.forceIntegerToFloat = options?.forceIntegerToFloat ?? false;

this.pos = 0;
@@ -174,7 +185,9 @@ export class Encoder<ContextType = undefined> {
throw new Error(`Too deep objects in depth ${depth}`);
}

if (object == null) {
if (object === null) {
this.encodeNil();
} else if (object === undefined && this.undefinedAsNil) {
this.encodeNil();
} else if (typeof object === "boolean") {
this.encodeBoolean(object);
36 changes: 35 additions & 1 deletion test/encode.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import assert from "assert";
import { encode, decode } from "../src/index.ts";
import { encode, decode, ExtensionCodec } from "../src/index.ts";

describe("encode", () => {
context("sortKeys", () => {
@@ -66,6 +66,40 @@ describe("encode", () => {
});
});

context("undefinedAsNil", () => {
const extensionCodec = new ExtensionCodec();
extensionCodec.register({
type: 0,
encode: (value) => (value === undefined ? new Uint8Array([0]) : null),
decode: () => undefined,
});

it("encodes { foo: undefined } as null by default", () => {
assert.deepStrictEqual(decode(encode({ foo: undefined, bar: 42 })), { foo: null, bar: 42 });
});

it("encodes { foo: undefined } as undefined with `undefinedAsNil: false`", () => {
assert.deepStrictEqual(
decode(encode({ foo: undefined, bar: 42 }, { extensionCodec, ignoreUndefined: false, undefinedAsNil: false }), {
extensionCodec,
}),
{
foo: undefined,
bar: 42,
},
);
});

it("encodes { foo: undefined } to { foo: null } with `undefinedAsNil: true`", () => {
assert.deepStrictEqual(
decode(encode({ foo: undefined, bar: 42 }, { extensionCodec, ignoreUndefined: false, undefinedAsNil: true }), {
extensionCodec,
}),
{ foo: null, bar: 42 },
);
});
});

context("ArrayBuffer as buffer", () => {
const buffer = encode([1, 2, 3]);
const arrayBuffer = buffer.buffer.slice(buffer.byteOffset, buffer.byteLength);