-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closes #19571: Create expansion_card.json #19689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The proposed change will only populate the addition profile type for NetBox installations which have yet been upgraded to v4.3.0 or later. Is that the intended effect? I don't want to get into a pattern of introducing additional profile types sporadically. The few which are provided for a default installation exist solely to provide examples. |
Yes, this was as discussed in the issue #19571 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harryajc , apologies for letting this languish.
We need to add exapansion_card.json
to the initial_profiles
tuple in 0206_load_module_type_profiles.load_initial_data
, otherwise the migration will not pick the new profile up.
@jnovinger All done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harryajc , one more change then this is ready to go. Apologies for not catching that earlier.
netbox/dcim/migrations/initial_data/module_type_profiles/expansion_card.json
Outdated
Show resolved
Hide resolved
@jnovinger Completed |
Adds Module Type as discussed in: #19571
Adds the Expansion card default module profile type