Skip to content

Closes #19571: Create expansion_card.json #19689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025

Conversation

harryajc
Copy link
Contributor

Adds Module Type as discussed in: #19571

Adds the Expansion card default module profile type

@jnovinger jnovinger changed the title Create expansion_card.json Closes #19571: Create expansion_card.json Jun 10, 2025
@jnovinger jnovinger requested review from a team and bctiemann and removed request for a team June 10, 2025 14:57
@jeremystretch
Copy link
Member

The proposed change will only populate the addition profile type for NetBox installations which have yet been upgraded to v4.3.0 or later. Is that the intended effect?

I don't want to get into a pattern of introducing additional profile types sporadically. The few which are provided for a default installation exist solely to provide examples.

@harryajc
Copy link
Contributor Author

Yes, this was as discussed in the issue #19571

@jeremystretch jeremystretch requested review from jnovinger and removed request for bctiemann July 3, 2025 15:06
Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harryajc , apologies for letting this languish.

We need to add exapansion_card.json to the initial_profiles tuple in 0206_load_module_type_profiles.load_initial_data, otherwise the migration will not pick the new profile up.

@harryajc
Copy link
Contributor Author

harryajc commented Jul 7, 2025

@harryajc , apologies for letting this languish.

We need to add exapansion_card.json to the initial_profiles tuple in 0206_load_module_type_profiles.load_initial_data, otherwise the migration will not pick the new profile up.

@jnovinger All done

@jnovinger jnovinger self-requested a review July 8, 2025 04:22
Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harryajc , one more change then this is ready to go. Apologies for not catching that earlier.

@harryajc
Copy link
Contributor Author

harryajc commented Jul 8, 2025

@jnovinger Completed

@jnovinger jnovinger merged commit 8fb8f4c into netbox-community:main Jul 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants