Skip to content

Handle permissions #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
Aug 5, 2025
Merged

Handle permissions #3500

merged 59 commits into from
Aug 5, 2025

Conversation

mpivchev
Copy link
Collaborator

@mpivchev mpivchev commented Jun 3, 2025 •
edited
Loading

mpivchev added 30 commits April 2, 2025 15:00
@mpivchev
Add read permission indicator + refactor
969f8ef 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
e92ac49 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into add-sh…
4647e9e 
…are-permissions
@mpivchev
WIP
b473eb3 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
fefa242 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Download and sync in advanced
f8a77ea 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Make download and sync button work
d6adbb2 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Remove download from normal permissions
935fdcf 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Remove unneeded db param
c2b8fd1 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Fix view only, allow edit, custom permissions
5889f64 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Fix link custom permissions being grayed out
219df5a 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into add-sh…
7fc9a8a 
…are-permissions
@mpivchev
Fix share screen not updating with sharees on first open
bd87c2b 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Refactor
e6098fb 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Add capabilities check for download limit
4637451 
This removes the api error

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
6aae638 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
b2140cc 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into add-sh…
e58020b 
…are-permissions

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Add quick options to link shares
2288d34 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
d5d5dbf 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Add selected flag to file drop
1d6ef84 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Remove share permission on email shares
05f0485 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Refactor
559ef53 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into add-sh…
5a450ac 
…are-permissions
@mpivchev
Fix shares not showing
9186989 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Fix ui
5375499 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Refactor
151ff20 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into add-sh…
7d67a04 
…are-permissions
@mpivchev
PR changes
b2fca73 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
PR changes
ebe9ab3 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
mpivchev added 4 commits June 3, 2025 13:24
@mpivchev
Refactor
2f9c8fc 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into handle…
ac9dfbe 
…-permissions

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
e6fb976 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
8fdecd5 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Copy link
Collaborator Author

mpivchev commented Jun 5, 2025 •
edited
Loading

Currently on iOS files in file provider cannot be directly modified in 3rd party apps like Word or Pages, as we use the old NSFileProviderExtension instead of the new NSFileProviderReplicatedExtension available for iOS16+. The old implementation uses virtual files instead of a full sandbox representation of files, which makes 2 way sync not possible for 3rd party apps, as they rely on the actual files instead of the virtual ones.

Implementing NSFileProviderReplicatedExtension has been discussed between me and @claucambra and can be a potential feature.

@tobiasKaminsky @marinofaggiana

More info here: https://developer.apple.com/documentation/fileprovider

@mpivchev
Copy link
Collaborator Author

mpivchev commented Jun 5, 2025

Moreover, with the new way of representing files (as a sandbox) we may lose the ability to show shared files in the file provider, due to privacy concerns or sync issues, but this must be investigated further

mpivchev added 3 commits June 6, 2025 10:51
@mpivchev
Remove delete option if no permission
faf1d6d 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
c2edd7d 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into handle…
039bd82 
…-permissions
@mpivchev mpivchev marked this pull request as ready for review June 10, 2025 12:14
mpivchev added 14 commits June 10, 2025 17:47
@mpivchev
WIP
a2b9ff3 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
15baef0 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Refactor
423de88 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Fix build
2462754 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into handle…
1063272 
…-permissions

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into handle…
dbcf918 
…-permissions
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into handle…
6d21f74 
…-permissions

Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
WIP
0ba5729 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into handle…
f4f99c7 
…-permissions
@mpivchev
WIP
4007984 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into handle…
491b8cf 
…-permissions
@mpivchev
PR improvements
a1f32f0 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into handle…
35f1f36 
…-permissions
@mpivchev
Merge branch 'master' of https://github.com/nextcloud/ios into handle…
e241ee4 
…-permissions
alperozturk96
alperozturk96 requested changes Aug 4, 2025
View reviewed changes
@mpivchev
PR changes
fa0ebaf 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
alperozturk96
alperozturk96 approved these changes Aug 4, 2025
View reviewed changes
iOSClient/Share/Advanced/NCShareCells.swift Outdated
@@ -65,11 +65,11 @@ enum NCUserPermission: CaseIterable, NCPermission {

var permissionBitFlag: Int {
switch self {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return switch here?

@mpivchev
PR fixes
c017b86 
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
@mpivchev mpivchev merged commit eb8fd7b into master Aug 5, 2025
4 checks passed
@mpivchev mpivchev deleted the handle-permissions branch August 7, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperozturk96 alperozturk96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpivchev @alperozturk96