Translation transformer handler #1554
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…formatted TranslateDefaultParser - All methods in the default parser are now protected to allow overriding - added getInterpolationReplacement() to allow customization of the replacements (getting values from the parameter object and formatting) - Improved formatter now renders Objects as JSON instead of [object Object] - Arrays are rendered with ", " instead of just ","
…nslation text is found. Isolated function to receive translation text from the translations with fallback to default language.
… TranslateStore to use better encapsulation. From outside, these event handlers are now visible as Observables and not EventEmitters to prevent users from outside calling emit(). Internally now using Subjects instead of EventEmitters. ngx-translate#1513
Instead, the function now uses the currentLang and defaultLang internally to get the values from the store directly.
getValue() is protected and can be overwritten. Fixed some lint warnings.
Add urls to link the repo with the npm page
Added Urls to repo
refactor(esLint): prefix
|
We already have this functionality in form of the translate compiler. |
|
I considered using the compiler to flatten the tree structure, but the cost is that it has to process the entire file every time it is loaded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a hook or extension point that allows modification of the raw translation value before the interpolation phase begins.
Issue: #1555