Skip to content

Compiling on Mac cause an error thrown by g++-12 #58219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vagostep opened this issue May 7, 2025 · 4 comments · May be fixed by #58239
Open

Compiling on Mac cause an error thrown by g++-12 #58219

vagostep opened this issue May 7, 2025 · 4 comments · May be fixed by #58239
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Comments

@vagostep
Copy link

vagostep commented May 7, 2025 •
edited
Loading

Version

22.x

Platform

Darwin Kernel Version 24.4.0

Subsystem

No response

What steps will reproduce the bug?

On a brand new Mac, following the BUILDING.md steps, specifically

To build Node.js:
export CXX=g++-12
•/configure
make -j4

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

It should compile successfully by following the BUILDING.md steps.

If I skip the export CXX=g++-12 command, it compiles successfully.

Maybe it is a documentation error, or a dependency step that is not working as expected in the latest Mac versions

What do you see instead?

An error:

cc1plus: error: '-Werror=undefined-inline': no option '-Wundefined-inline'; did you mean '-Wundefined-do-loop'?

Additional information

No response
@vagostep vagostep changed the title Compiling on Mac Compiling on Mac cause an error by g++-12 May 7, 2025
@vagostep vagostep changed the title Compiling on Mac cause an error by g++-12 Compiling on Mac cause an error thrown by g++-12 May 7, 2025
@targos
Copy link
Member

targos commented May 8, 2025

export CXX=g++-12 was added recently (4c27393), but it's wrong for mac. You can omit this step.

@vagostep
Copy link
Author

vagostep commented May 8, 2025

@targos yes! By skipping it, it works.

should we update the doc or should we wait for it to work again?

@targos
Copy link
Member

targos commented May 8, 2025

The documentation should be updated. Would you like to try and open a PR?

@targos targos added doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. labels May 8, 2025
@vagostep
Copy link
Author

vagostep commented May 8, 2025

@targos sure! on it.

vagostep added a commit to vagostep/node that referenced this issue May 8, 2025
@vagostep
doc: spliting building steps for unix and macos
0b7cf95 
Currently, there is an error when executing export: CXX=g++-12 on macOS. Without it, it compiles fine. So, we split the step into two caterogies: steps for unix and steps for macOS

Fixes: nodejs#58219
@vagostep vagostep linked a pull request May 8, 2025 that will close this issue
Open
vagostep added a commit to vagostep/node that referenced this issue May 15, 2025
@vagostep
doc: spliting building steps for unix and macos
d646198 
Currently, there is an error when executing export: CXX=g++-12 on macOS. Without it, it compiles fine. So, we split the step into two caterogies: steps for unix and steps for macOS

Fixes: nodejs#58219

Restoring previous BUILDING.md

new doc proposal for g++-12 export command

removing non related line change

restoring end of file

restoring comment proposal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: spliting building steps for unix and macos vagostep/node
2 participants
@targos @vagostep