deps: update V8 to 13.6 #58070

targos · 2025-04-29T06:11:23Z

Same as #57753, without compatibility patches for MSVC and armv7.

Notable changes:

nodejs-github-bot · 2025-04-29T06:11:28Z

targos · 2025-04-29T08:06:30Z

We still have this consistent macOS test failure on GitHub actions:

 Path: sequential/test-error-serdes
Error: --- stderr ---
node:internal/streams/readable:90
const FastBuffer = Buffer[SymbolSpecies];
                         ^

RangeError: Maximum call stack size exceeded
    at node:internal/streams/readable:90:26
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:398:7)
    at requireBuiltin (node:internal/bootstrap/realm:429:14)
    at node:internal/streams/duplex:39:18
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:398:7)
    at requireBuiltin (node:internal/bootstrap/realm:429:14)
    at node:internal/streams/pipeline:16:16
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:398:7)
    at requireBuiltin (node:internal/bootstrap/realm:429:14)
    at node:internal/streams/compose:7:22

Node.js v24.0.0-pre
Command: out/Release/node --expose-internals --stack-size=64 --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/runner/work/node/node/node/test/sequential/test-error-serdes.js

codecov · 2025-04-29T09:24:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (102d8cf) to head (fb09a88).
Report is 45 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58070      +/-   ##
==========================================
- Coverage   90.20%   89.63%   -0.57%     
==========================================
  Files         630      630              
  Lines      186446   186470      +24     
  Branches    36622    36306     -316     
==========================================
- Hits       168189   167149    -1040     
- Misses      11051    12088    +1037     
- Partials     7206     7233      +27

see 118 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

legendecas · 2025-04-29T11:06:38Z

@targos I think we can safely increase the --stack-size flag in the test from 64 to some value like 128 or 256 to quickly remediate the failure. However, I did not find it is necessary to rely on the stack size in this test at all: #58075.

nodejs-github-bot · 2025-04-29T15:03:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66508/

nodejs-github-bot · 2025-04-29T15:03:29Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6520/

nodejs-github-bot · 2025-04-29T15:05:05Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6520/

nodejs-github-bot · 2025-04-29T15:06:40Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6520/

targos · 2025-04-29T20:13:47Z

Now there are failing pummel/test-heapdump-... tests 😞

https://ci.nodejs.org/job/node-test-commit-linux-containered/50344/

targos · 2025-04-29T20:15:11Z

And timeouts too while building addons on Windows

joyeecheung · 2025-04-29T20:24:29Z

It passed in https://ci.nodejs.org/job/node-test-pull-request/66495/ and https://ci.nodejs.org/job/node-test-commit/79461/ so could come from the diff?

targos · 2025-04-29T20:26:54Z

It's probably me being too optimistic when I removed #47450 (df034a3). I'll add it back when I rebase to fix the node_buffer.cc conflict.

joyeecheung · 2025-04-30T01:16:57Z

If it's caused by enabling concurrent sparkplug it's likely #54918 (which might be fixed by #58047 but I will need more time to reason it out). For unblocking 24 it's better to keep it disabled for now.

nodejs-github-bot · 2025-04-30T05:39:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66512/

targos · 2025-04-30T07:45:21Z

CI is looking better.

targos · 2025-04-30T09:39:08Z

There are still issues with Windows tests. /cc @StefanStojanovic

aduh95 · 2025-04-30T11:04:59Z

pummel/test-heapdump-zlib is quite flaky on GHA test-linux (failed 7/20 times)

nodejs-github-bot · 2025-04-30T14:37:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66516/

targos · 2025-04-30T14:38:20Z

Another pummel/test-heapdump-shadow-realm failed in one of the containered jobs https://ci.nodejs.org/job/node-test-commit-linux-containered/50349/

PR-URL: nodejs/node#58070 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

GCC emits warnings because of the trailing backslashes. PR-URL: nodejs/node#58070 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>