bugfix: key-rotation + reply SURBs #5876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
jstuczyn
force-pushed
the
bugfix/surb-refresh
branch
from
1c65bf1 to
01d0fb1
Compare
jstuczyn
force-pushed
the
bugfix/surb-refresh
branch
3 times, most recently
from
e45d8d7 to
5dfec17
Compare
jstuczyn
force-pushed
the
bugfix/surb-refresh
branch
from
5dfec17 to
0765e55
Compare
jstuczyn
force-pushed
the
bugfix/surb-refresh
branch
from
0765e55 to
16f5392
Compare
jstuczyn
force-pushed
the
bugfix/surb-refresh
branch
4 times, most recently
from
af3c349 to
ff051cc
Compare
jstuczyn
force-pushed
the
bugfix/surb-refresh
branch
from
ff051cc to
a0766b0
Compare
jstuczyn
force-pushed
the
bugfix/surb-refresh
branch
from
a0766b0 to
f59c318
Compare
jstuczyn
force-pushed
the
bugfix/surb-refresh
branch
from
f59c318 to
cb8283c
Compare
Merged
|
It would be better to replace log with tracing or run clippy in a separate PR to avoid such a massive bloat. |
includes, but is not limited to: unconditionally reseting sender tag on restart, limiting number of surb re-requests, resetting stale surbs on load
in hindsight that's what I should I have done. I got annoyed by red CI and just fixed the issues here. |
benedettadavico
approved these changes
Jul 4, 2025
jstuczyn
force-pushed
the
bugfix/surb-refresh
branch
from
759957e to
1054567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR should hopefully, probably, maybe, I think resolve the issue of suddenly running out of usable reply SURBs when a new key rotation occurs.
This change is