Skip to content

ChangeMethodAccessLevelVisitor should also consider Space #5592

New issue
New issue
Open
Bug
#5621
Open
ChangeMethodAccessLevelVisitor should also consider Space#5592
Bug
#5621
Labels
enhancementNew feature or requestgood first issueGood for newcomers
@Laurens-W

Description

@Laurens-W
Laurens-W
opened on Jun 10, 2025

What problem are you trying to solve?

ChangeMethodAccessLevelVisitor should probably also copy over the Space from the previous modifier as the auto formatter doesn't influence spacing when comments are involved (neither does IntelliJ)

rewrite/rewrite-java/src/main/java/org/openrewrite/java/ChangeMethodAccessLevelVisitor.java

Lines 114 to 118 in 3fdb4b7

if (!modifierComments.isEmpty()) {
J.Modifier nextModifier = mod.withComments(ListUtils.concatAll(new ArrayList<>(modifierComments), mod.getComments()));
modifierComments.clear();
return nextModifier;
}

This test is a good show of what we don't want happening (see the dataSource3 bean)
We'd rather update the expectation

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestgood first issueGood for newcomers

    Type

    Projects

    OpenRewrite

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions