-
Notifications
You must be signed in to change notification settings - Fork 465
Adding recipe for adding comment to method invocations & clarifying a description for AddCommentToMethod
recipe.
#5622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
steve-aom-elliott
merged 5 commits into
main
from
recipe-add-comment-to-method-invocation
Jul 18, 2025
Merged
Adding recipe for adding comment to method invocations & clarifying a description for AddCommentToMethod
recipe.
#5622
steve-aom-elliott
merged 5 commits into
main
from
recipe-add-comment-to-method-invocation
Jul 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rewrite-java/src/main/java/org/openrewrite/java/AddCommentToMethodInvocations.java
Outdated
Show resolved
Hide resolved
aa5a37b
to
3ee8f26
Compare
timtebeek
reviewed
Jun 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is just to make it easier to diff AddCommentToMethod
and AddCommentToMethodInvocation
.
timtebeek
reviewed
Jun 16, 2025
rewrite-java/src/main/java/org/openrewrite/java/AddCommentToMethodInvocations.java
Outdated
Show resolved
Hide resolved
f9c9b54
to
057ef16
Compare
057ef16
to
4fc7c4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- rewrite-maven/src/test/java/org/openrewrite/maven/MavenParserTest.java
- lines 4048-4049
0f04611
to
a57595f
Compare
0f656f6
to
7d028c8
Compare
7d028c8
to
959800d
Compare
timtebeek
approved these changes
Jul 17, 2025
…nal constant to the `MethodMatcher` for the description to be able to distinguish between "invocations" and "declarations" when these constants get used in descriptions to lessen potential confusion.
959800d
to
c87983c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
recipe
Requested Recipe
test provided
Already replicated with a unit test, using JUnit pioneer's ExpectedToFail
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added
AddCommentToMethodInvocations
, as well as adding an additional constant to theMethodMatcher
for the description to be able to distinguish between "invocations" and "declarations" when these constants get used in descriptions of various recipes to lessen potential confusion.Checklist