Skip to content

Conversation

steve-aom-elliott
Copy link
Contributor

What's changed?

Added AddCommentToMethodInvocations, as well as adding an additional constant to the MethodMatcher for the description to be able to distinguish between "invocations" and "declarations" when these constants get used in descriptions of various recipes to lessen potential confusion.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@steve-aom-elliott steve-aom-elliott self-assigned this Jun 13, 2025
@steve-aom-elliott steve-aom-elliott added enhancement New feature or request recipe Requested Recipe labels Jun 13, 2025
@steve-aom-elliott steve-aom-elliott added the test provided Already replicated with a unit test, using JUnit pioneer's ExpectedToFail label Jun 13, 2025
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Jun 13, 2025
@steve-aom-elliott steve-aom-elliott force-pushed the recipe-add-comment-to-method-invocation branch from aa5a37b to 3ee8f26 Compare June 13, 2025 20:36
@steve-aom-elliott steve-aom-elliott marked this pull request as ready for review June 13, 2025 21:34
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is just to make it easier to diff AddCommentToMethod and AddCommentToMethodInvocation.

@steve-aom-elliott steve-aom-elliott force-pushed the recipe-add-comment-to-method-invocation branch from f9c9b54 to 057ef16 Compare June 16, 2025 18:59
@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite Jun 16, 2025
@steve-aom-elliott steve-aom-elliott force-pushed the recipe-add-comment-to-method-invocation branch from 057ef16 to 4fc7c4e Compare June 17, 2025 18:57
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-maven/src/test/java/org/openrewrite/maven/MavenParserTest.java
    • lines 4048-4049

@steve-aom-elliott steve-aom-elliott force-pushed the recipe-add-comment-to-method-invocation branch 2 times, most recently from 0f04611 to a57595f Compare June 26, 2025 19:11
@steve-aom-elliott steve-aom-elliott force-pushed the recipe-add-comment-to-method-invocation branch 3 times, most recently from 0f656f6 to 7d028c8 Compare July 14, 2025 13:27
@steve-aom-elliott steve-aom-elliott force-pushed the recipe-add-comment-to-method-invocation branch from 7d028c8 to 959800d Compare July 17, 2025 20:30
@steve-aom-elliott steve-aom-elliott force-pushed the recipe-add-comment-to-method-invocation branch from 959800d to c87983c Compare July 18, 2025 13:21
@steve-aom-elliott steve-aom-elliott merged commit 5de8133 into main Jul 18, 2025
2 checks passed
@steve-aom-elliott steve-aom-elliott deleted the recipe-add-comment-to-method-invocation branch July 18, 2025 13:55
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request recipe Requested Recipe test provided Already replicated with a unit test, using JUnit pioneer's ExpectedToFail
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants