UpgradeDependencyVersion recipe does not update properties defined in parent #5633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevanlingen
force-pushed
the
upgrade-dependency-version-use-parent-build-gradle-to-define-properties
branch
from
fb65285 to
bcffd04
Compare
jevanlingen
force-pushed
the
upgrade-dependency-version-use-parent-build-gradle-to-define-properties
branch
from
ee91176 to
f381ea7
Compare
jevanlingen
commented
Jun 18, 2025
| @@ -801,6 +801,111 @@ void versionInParentSubprojectDefinitionWithPropertiesFiles() { | |||
| ); | |||
| } | |||
|
|
|||
| @Test | |||
| void versionInParentPropertiesFiles() { | |||
There was a problem hiding this comment.
💡 This test did already pass before this PR. It's just an extra test to prove this kind of setup does also work.
|
please give time to @jkschneider to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
When a parent build.gradle defines a property and it's used in a submodule, this property is updated as well.
Anything in particular you'd like reviewers to focus on?
The recipe before this change went through all the method invocations to search for dependency placeholders. Once found, it put the data as cursor message on the compilation unit and then afterwards updates method assignments. This does not work for a parent-child relationship with variables, because we are now talking of multiple source files. So I moved (and refactored) the logic to the scanning phase.
Checklist