Fix/numeric provider state param #506
Conversation
see if we get flakey tests prior to implementing PR with musl support
…at <string, string> this allows for passing of simple string, int and json payloads, rather than simply string
adamrodger
left a comment
adamrodger
left a comment
There was a problem hiding this comment.
If the API is to open up to allow absolutely anything be used as a provider state parameter and change the public API then I'd want to see more significant testing of "weird" values.
So there are obvious things like what does double.NaN do? What about null or other nullable value types? What about complex objects? What about random classes being passed in? What about string-like types such as StringBuilder and Span<char>? What about arrays or other collection types? Stuff like that.
We also need a lot of round trip testing, to make sure that the provider tests can actually deserialise these things. I know we expect users to handle provider states themselves but we at least need to make sure that System.Text.Json can round trip these things given that's the main serialiser we support.
Using object in a public API creates a lot of opportunity for that to all go wrong so I think we need much more comprehensive testing when we're serialising potentially anything.
| /// <param name="parameters">Provider state parameters</param> | ||
| /// <returns>Fluent builder</returns> | ||
| IMessageBuilderV3 Given(string providerState, IDictionary<string, string> parameters); | ||
| IMessageBuilderV3 Given(string providerState, IDictionary<string, object> parameters); |
There was a problem hiding this comment.
Note that this is a breaking change to the public API
There was a problem hiding this comment.
Could it be a dynamic ? It would be aligned with WithContent.
Could it be planned for the next major version ?
| => NativeInterop.GivenWithParam(this.interaction, description, name, value).CheckInteropSuccess(); | ||
| public void GivenWithParam(string description, string name, object value) | ||
| { | ||
| var jsonValue = System.Text.Json.JsonSerializer.Serialize(value); |
There was a problem hiding this comment.
style: Don't use var when it's not obvious what the type is
style: Don't use fully qualified references inline, use an import instead
| using System.Runtime.InteropServices; | ||
| using PactNet.Interop; | ||
|
|
||
| using System.Text.Json.Serialization; |
There was a problem hiding this comment.
style: Blank line after import statements
3 participants
fixes #449
relates to