Skip to content

Improving pattern linking to include View Alls #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2017

Conversation

EvanLovely
Copy link
Member

Currently, the link variable for linking between patterns only supports linking to a single pattern, this adds the ability to link to the View Alls such as "Atoms > View All" or "Atoms > Forms > View All".

@bmuenzenmeyer Is this implemented in Node version?

@EvanLovely EvanLovely merged commit 75914bd into master Oct 13, 2017
@EvanLovely EvanLovely deleted the feature/pattern-link-improvements branch October 13, 2017 16:34
@EvanLovely
Copy link
Member Author

EvanLovely commented Oct 13, 2017

To use: Simply copy the Pattern URL string: In url with ?p=viewall-atoms-all, you'd use link.viewall-atoms-all in Mustache or link['viewall-atoms-all'] in Twig.

@bmuenzenmeyer
Copy link
Member

Node supports patterns only. It would probably be pretty simple to implement, however. This would be a spec enhancement, IMO.

@bradfrost
Copy link
Member

I like this idea, especially keeping in mind the efforts to evolve PL into more of a style guide tool as well. Would be helpful to be able to link to a cluster of patterns.

@EvanLovely
Copy link
Member Author

Added as issue to spec to better track: pattern-lab/the-spec#35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants