Skip to content

Provide better name for validate_email option #6312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025

Conversation

josevalim
Copy link
Member

The code also validates if the email changed but I think adding uniqueness to the option is good enough?

@SteffenDE
Copy link
Contributor

Do you have more context about this? Looking at this I find just validate_email fine as is, but I may be missing the problem.

@josevalim
Copy link
Member Author

The issue is that we do other email validations, such as on the format, even when validate_email: false.

@SteffenDE SteffenDE merged commit ae3beeb into main Jul 2, 2025
11 of 15 checks passed
@SteffenDE SteffenDE deleted the jv-better-validate-email-option branch July 2, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants