Skip to content

Be a smidge more error tolerant? #1003

@thejcannon

Description

@thejcannon
Contributor

While playing around with using setuptools_scm I hit more than a few AssertionErrors with the only context being the code and traceback.

Perhaps these could be improved with an assertion message, or even a ValueError instead 😄

Activity

RonnyPfannschmidt

RonnyPfannschmidt commented on Jan 18, 2024

@RonnyPfannschmidt
Contributor

Absolutely

thejcannon

thejcannon commented on Jan 18, 2024

@thejcannon
ContributorAuthor

FYI I'll re-create those situations and bake you a perfectly crisp PR 🧑‍🍳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @RonnyPfannschmidt@thejcannon

      Issue actions

        Be a smidge more error tolerant? · Issue #1003 · pypa/setuptools-scm