Skip to content

feat: allow reconcilers to override their configuration at runtime #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

metacosm
Copy link
Member

@metacosm metacosm commented May 7, 2025

If a reconciler implements ConfigurableReconciler, then QOSDK will
derive a new configuration for the reconciler by calling
updateConfigurationFrom before registering the reconciler with this
new configuration.

If a reconciler implements `ConfigurableReconciler`, then QOSDK will
derive a new configuration for the reconciler by calling
`updateConfigurationFrom` before registering the reconciler with this
new configuration.
Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is better. But wasn't there also a test?

@metacosm
Copy link
Member Author

metacosm commented May 9, 2025

I think this is better. But wasn't there also a test?

There isn't at the moment, but I need to add some, indeed.
@goldmann would this solution work for you?

@goldmann
Copy link
Contributor

goldmann commented May 9, 2025

Yes, yep! Will work just fine!

@metacosm
Copy link
Member Author

metacosm commented May 9, 2025

Thanks. Closing this PR as this will instead be supported in extensions instead of JOSDK core.

@metacosm metacosm closed this May 9, 2025
@metacosm metacosm deleted the configure-controller branch May 9, 2025 07:50
@goldmann
Copy link
Contributor

I'm a little bit puzzled on why this was closed. Isn't this the extension repo where this should be living? Or maybe I'm understanding it wrongly? What is the relation of operator-framework/java-operator-sdk#2784 to this PR?

Thanks and sorry!

@metacosm metacosm restored the configure-controller branch May 12, 2025 07:26
@metacosm
Copy link
Member Author

I'm puzzled as well! 😅
I guess I was tired and closed the wrong PR. 🤦🏼
Thank you!

@metacosm metacosm reopened this May 12, 2025
@metacosm
Copy link
Member Author

I'm a little bit puzzled on why this was closed. Isn't this the extension repo where this should be living? Or maybe I'm understanding it wrongly? What is the relation of operator-framework/java-operator-sdk#2784 to this PR?

That PR is a change I thought would be needed but isn't after all. This is a tangential issue that is also kind of orthogonal (if that makes any sense!) 😁
Strictly speaking, one is not needed for the other.

@metacosm metacosm marked this pull request as ready for review May 19, 2025 09:23
@metacosm metacosm requested a review from a team as a code owner May 19, 2025 09:23
@metacosm metacosm merged commit 5b354c0 into main May 19, 2025
13 checks passed
@metacosm metacosm deleted the configure-controller branch May 19, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants