Update Application.run() behavior #932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes
Application.run()
with thecount
param now counts the outputs instead of messages.It makes the behavior easier to reason about for the users, and also simplifies the inner logic.
For example, we no longer need to handle messages from the repartition topics separately.
Application.run()
withcount
ortimeout
parameters can now accumulate and return the processed outputs for further debugging.This approach is less manual than using a
ListSink
.StreamingDataFrame.group_by()
now filters the data after sending it to the repartition topic to avoid double-counting