-
Notifications
You must be signed in to change notification settings - Fork 6.6k
[core] split dask and modin tests #54121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request aims to split the combined dask & modin tests into separate CI steps to accommodate a change in the Python version required for dask.
- Separate CI steps for dask tests and modin tests
- Updated command parameters and labels to reflect the split
Comments suppressed due to low confidence (1)
.buildkite/core.rayci.yml:193
- The removal of the '--parallelism-per-worker 2' parameter in the modin tests step may affect test execution concurrency. Please confirm if this is intentional or if a similar parallelism configuration should be applied for modin tests as well.
--build-name datalbuild
dask will need to use a different python version after upgrade Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
df0ae4a
to
d845cb3
Compare
this is for accepting changes from #52589 which needs to run dask tests on python 3.12+ |
I understand the concern on setup overhead. we will hopefully optimize that part out in the next quarter. |
dask will need to use a different python version after upgrade Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
dask will need to use a different python version after upgrade Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
dask will need to use a different python version after upgrade Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
dask will need to use a different python version after upgrade Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Goutam V <goutam@anyscale.com>
dask will need to use a different python version after upgrade