[data] split dask and modin tests #54122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as dask tests will require running on python 3.12+ after upgrade; modin does not Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
There was a problem hiding this comment.
Pull Request Overview
This PR splits the tests for Modin and Dask to accommodate the Python 3.12+ requirements for Dask while keeping Modin tests unaffected.
- Added a new test file (test_ecosystem_modin.py) with Modin-specific tests.
- Removed the Modin tests from the Dask test file (test_ecosystem_dask.py).
- Updated the BUILD file to define separate test targets for Modin and Dask.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/ray/data/tests/test_ecosystem_modin.py | Introduces dedicated tests for Modin functionality. |
| python/ray/data/tests/test_ecosystem_dask.py | Removes Modin test cases, retaining only Dask-related tests. |
| python/ray/data/BUILD | Updates test targets to reflect the split between Modin and Dask. |
Comment on lines
+11
to
+16
| def test_from_modin(ray_start_regular_shared): | ||
| import modin.pandas as mopd | ||
|
|
||
| df = pd.DataFrame( | ||
| {"one": list(range(100)), "two": list(range(100))}, | ||
| ) |
There was a problem hiding this comment.
[nitpick] The DataFrame initialization logic is repeated in both test_from_modin and test_to_modin. Consider refactoring this into a fixture or helper function to improve code maintainability.
Suggested change
| def test_from_modin(ray_start_regular_shared): | |
| import modin.pandas as mopd | |
| df = pd.DataFrame( | |
| {"one": list(range(100)), "two": list(range(100))}, | |
| ) | |
| def _create_test_dataframe(): | |
| return pd.DataFrame( | |
| {"one": list(range(100)), "two": list(range(100))}, | |
| ) | |
| def test_from_modin(ray_start_regular_shared): | |
| import modin.pandas as mopd | |
| df = _create_test_dataframe() |
Copilot uses AI. Check for mistakes.
|
this is required for accepting #52589 |
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
as dask tests will require running on python 3.12+ after upgrade; modin does not also adds `dask` tag, for running on a separate test job in the future. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
lk-chen
pushed a commit
to alexeykudinkin/ray
that referenced
this pull request
Jun 29, 2025
as dask tests will require running on python 3.12+ after upgrade; modin does not also adds `dask` tag, for running on a separate test job in the future. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
as dask tests will require running on python 3.12+ after upgrade; modin does not also adds `dask` tag, for running on a separate test job in the future. Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
goutamvenkat-anyscale
pushed a commit
to goutamvenkat-anyscale/ray
that referenced
this pull request
Jul 4, 2025
as dask tests will require running on python 3.12+ after upgrade; modin does not also adds `dask` tag, for running on a separate test job in the future. Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Goutam V <goutam@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as dask tests will require running on python 3.12+ after upgrade; modin does not
also adds
dasktag, for running on a separate test job in the future.