-
Notifications
You must be signed in to change notification settings - Fork 6.6k
[Data] Handle Huggingface Integration CI test failures #54128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
omatthew98
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for cleaning this up @srinathk10, this is a massive improvement!!
raulchen
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the clean-up!
Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
…4128) Handle Huggingface Integration CI test failures. **`from_arrow` API** - Updated `from_arrow` API to support `override_num_blocks`. This is similar to `from_pandas` API signature. **`from_huggingface` API** - Leverage `from_arrow` API update with `override_num_blocks` to support `from_huggingface` API with `override_num_blocks` for the case of fallback to non-streaming Hugging Face Dataset. **Mock huggingface Dataset for CI** - Added `mock_hf_dataset`, `mock_hf_dataset_dict` and `mock_hf_iterable_dataset` test fixture. - Removed dependency on huggingface connectivity from CI. - `test_huggingface.py` passes now in 10 secs instead of 80ish secs. --------- Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
lk-chen
pushed a commit
to alexeykudinkin/ray
that referenced
this pull request
Jun 29, 2025
…4128) Handle Huggingface Integration CI test failures. **`from_arrow` API** - Updated `from_arrow` API to support `override_num_blocks`. This is similar to `from_pandas` API signature. **`from_huggingface` API** - Leverage `from_arrow` API update with `override_num_blocks` to support `from_huggingface` API with `override_num_blocks` for the case of fallback to non-streaming Hugging Face Dataset. **Mock huggingface Dataset for CI** - Added `mock_hf_dataset`, `mock_hf_dataset_dict` and `mock_hf_iterable_dataset` test fixture. - Removed dependency on huggingface connectivity from CI. - `test_huggingface.py` passes now in 10 secs instead of 80ish secs. --------- Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
Handle Huggingface Integration CI test failures. **`from_arrow` API** - Updated `from_arrow` API to support `override_num_blocks`. This is similar to `from_pandas` API signature. **`from_huggingface` API** - Leverage `from_arrow` API update with `override_num_blocks` to support `from_huggingface` API with `override_num_blocks` for the case of fallback to non-streaming Hugging Face Dataset. **Mock huggingface Dataset for CI** - Added `mock_hf_dataset`, `mock_hf_dataset_dict` and `mock_hf_iterable_dataset` test fixture. - Removed dependency on huggingface connectivity from CI. - `test_huggingface.py` passes now in 10 secs instead of 80ish secs. --------- Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
goutamvenkat-anyscale
pushed a commit
to goutamvenkat-anyscale/ray
that referenced
this pull request
Jul 4, 2025
…4128) Handle Huggingface Integration CI test failures. **`from_arrow` API** - Updated `from_arrow` API to support `override_num_blocks`. This is similar to `from_pandas` API signature. **`from_huggingface` API** - Leverage `from_arrow` API update with `override_num_blocks` to support `from_huggingface` API with `override_num_blocks` for the case of fallback to non-streaming Hugging Face Dataset. **Mock huggingface Dataset for CI** - Added `mock_hf_dataset`, `mock_hf_dataset_dict` and `mock_hf_iterable_dataset` test fixture. - Removed dependency on huggingface connectivity from CI. - `test_huggingface.py` passes now in 10 secs instead of 80ish secs. --------- Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com> Signed-off-by: Goutam V <goutam@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Handle Huggingface Integration CI test failures.
from_arrow
APIfrom_arrow
API to supportoverride_num_blocks
. This is similar tofrom_pandas
API signature.from_huggingface
APIfrom_arrow
API update withoverride_num_blocks
to supportfrom_huggingface
API withoverride_num_blocks
for the case of fallback to non-streaming Hugging Face Dataset.Mock huggingface Dataset for CI
mock_hf_dataset
,mock_hf_dataset_dict
andmock_hf_iterable_dataset
test fixture.test_huggingface.py
passes now in 10 secs instead of 80ish secs.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.