Skip to content

[Data] Handle Huggingface Integration CI test failures #54128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2025

Conversation

srinathk10
Copy link
Contributor

@srinathk10 srinathk10 commented Jun 26, 2025

Why are these changes needed?

Handle Huggingface Integration CI test failures.

from_arrow API

  • Updated from_arrow API to support override_num_blocks. This is similar to from_pandas API signature.

from_huggingface API

  • Leverage from_arrow API update with override_num_blocks to support from_huggingface API with override_num_blocks for the case of fallback to non-streaming Hugging Face Dataset.

Mock huggingface Dataset for CI

  • Added mock_hf_dataset, mock_hf_dataset_dict and mock_hf_iterable_dataset test fixture.
  • Removed dependency on huggingface connectivity from CI.
  • test_huggingface.py passes now in 10 secs instead of 80ish secs.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
@srinathk10 srinathk10 requested a review from a team as a code owner June 26, 2025 05:07
srinathk10 and others added 2 commits June 25, 2025 22:07
Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
@srinathk10 srinathk10 added the go add ONLY when ready to merge, run all tests label Jun 26, 2025
Copy link
Contributor

@omatthew98 omatthew98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for cleaning this up @srinathk10, this is a massive improvement!!

Copy link
Contributor

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the clean-up!

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
@raulchen raulchen merged commit 9b5008c into master Jun 26, 2025
5 checks passed
@raulchen raulchen deleted the srinathk10/hf-dataset-fixes branch June 26, 2025 22:14
minerharry pushed a commit to minerharry/ray that referenced this pull request Jun 27, 2025
…4128)

Handle Huggingface Integration CI test failures.

**`from_arrow` API**
- Updated `from_arrow` API to support `override_num_blocks`. This is
similar to `from_pandas` API signature.

**`from_huggingface` API**
- Leverage `from_arrow` API update with `override_num_blocks` to support
`from_huggingface` API with `override_num_blocks` for the case of
fallback to non-streaming Hugging Face Dataset.

**Mock huggingface Dataset for CI**
- Added `mock_hf_dataset`, `mock_hf_dataset_dict` and
`mock_hf_iterable_dataset` test fixture.
- Removed dependency on huggingface connectivity from CI.
- `test_huggingface.py` passes now in 10 secs instead of 80ish secs.
---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
lk-chen pushed a commit to alexeykudinkin/ray that referenced this pull request Jun 29, 2025
…4128)

Handle Huggingface Integration CI test failures.

**`from_arrow` API**
- Updated `from_arrow` API to support `override_num_blocks`. This is
similar to `from_pandas` API signature.

**`from_huggingface` API**
- Leverage `from_arrow` API update with `override_num_blocks` to support
`from_huggingface` API with `override_num_blocks` for the case of
fallback to non-streaming Hugging Face Dataset.

**Mock huggingface Dataset for CI**
- Added `mock_hf_dataset`, `mock_hf_dataset_dict` and
`mock_hf_iterable_dataset` test fixture.
- Removed dependency on huggingface connectivity from CI.
- `test_huggingface.py` passes now in 10 secs instead of 80ish secs.
---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
Handle Huggingface Integration CI test failures.

**`from_arrow` API**
- Updated `from_arrow` API to support `override_num_blocks`. This is
similar to `from_pandas` API signature.

**`from_huggingface` API**
- Leverage `from_arrow` API update with `override_num_blocks` to support
`from_huggingface` API with `override_num_blocks` for the case of
fallback to non-streaming Hugging Face Dataset.

**Mock huggingface Dataset for CI**
- Added `mock_hf_dataset`, `mock_hf_dataset_dict` and
`mock_hf_iterable_dataset` test fixture.
- Removed dependency on huggingface connectivity from CI.
- `test_huggingface.py` passes now in 10 secs instead of 80ish secs.
---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
goutamvenkat-anyscale pushed a commit to goutamvenkat-anyscale/ray that referenced this pull request Jul 4, 2025
…4128)

Handle Huggingface Integration CI test failures.

**`from_arrow` API**
- Updated `from_arrow` API to support `override_num_blocks`. This is
similar to `from_pandas` API signature.

**`from_huggingface` API**
- Leverage `from_arrow` API update with `override_num_blocks` to support
`from_huggingface` API with `override_num_blocks` for the case of
fallback to non-streaming Hugging Face Dataset.

**Mock huggingface Dataset for CI**
- Added `mock_hf_dataset`, `mock_hf_dataset_dict` and
`mock_hf_iterable_dataset` test fixture.
- Removed dependency on huggingface connectivity from CI.
- `test_huggingface.py` passes now in 10 secs instead of 80ish secs.
---------

Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Signed-off-by: Goutam V <goutam@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants