Add note when inherent impl for a alias type defined outside of the crate #142415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
rustbot
added
S-waiting-on-review
| error[E0116]: cannot define inherent `impl` for a type outside of the crate where the type is defined | ||
| --> $DIR/insufficient-suggestion-issue-141679.rs:6:1 | ||
| | | ||
| LL | impl Function {} |
There was a problem hiding this comment.
It would be nice to point out the span of the type alias, and explain that the orphan checking rules apply to that type.
…rate Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
xizheyin
commented
Jun 12, 2025
Comment on lines
+1
to
+15
| error[E0116]: cannot define inherent `impl` for a type outside of the crate where the type is defined | ||
| --> $DIR/insufficient-suggestion-issue-141679.rs:6:1 | ||
| | | ||
| LL | impl Function {} | ||
| | ^^^^^^^^^^^^^ impl for type defined outside of crate | ||
| | | ||
| = note: define and implement a trait or new type instead, for more details about orphan rules, see <https://doc.rust-lang.org/reference/items/implementations.html?highlight=orphan#orphan-rules> | ||
| note: `Function` does not define a new type, just alias of `Rc<Foo>` defined here | ||
| --> $DIR/insufficient-suggestion-issue-141679.rs:4:1 | ||
| | | ||
| LL | pub type Function = Rc<Foo>; | ||
| | ^^^^^^^^^^^^^^^^^ | ||
|
|
||
| error: aborting due to 1 previous error | ||
|
|
There was a problem hiding this comment.
It give a link to rust reference for explaining the orphan rules. and present the span where the alias is defined.
|
r? compiler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141679
r? compiler