Support include and exclude for property groups #660
+910
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razor-x
commented
Jun 17, 2025
| --- | ||
|
|
||
|
|
||
| ## Errors |
There was a problem hiding this comment.
@DebbieAtSeam Didn't realize this until now, but we will need to be able to group the errors and warnings.
| @@ -1,5 +1,867 @@ | |||
| # Thermostats | |||
|
|
|||
| ## The device Object | |||
There was a problem hiding this comment.
@razor-x How do we get this to say "The thermostat Object" instead of the "The device Object"?
There was a problem hiding this comment.
There is no thermostat object. This is a device resource. Should we say something else here that is more accurate, e.g., that these are the relevant properties of device for using the /thermostats API? Let's decide on the language first and we can adjust the template. We will likely need to incorporate this into the path metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renders device properties for the thermostat group on
/thermostats.