fix(scheduler): adjust yield timing logic to improve task scheduling … #2483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…accuracy - Added maxDeadline to handle max yield interval timing correctly - Updated shouldYieldToHost logic to consider maxDeadline for better responsiveness - Fixed parameter types and signatures for consistency - Minor refactoring for clarity without changing core behavior
🦋 Changeset detectedLatest commit: 2ba9ca0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes a bug related to the maxDeadline timing in the scheduler, improving yield behavior. It also removes the unused hasTimeRemaining boolean parameter from flushWork, workLoop, and the scheduledCallback function, resulting in cleaner and easier-to-maintain code.
Details:
Corrected the comparison with maxDeadline in shouldYieldToHost to ensure the scheduler yields control correctly and timely.
Removed the unused hasTimeRemaining parameter from core scheduler functions, simplifying the code base
No new functionality added — purely a bug fix and code cleanup