ManagementContextAutoConfiguration adds a property source that degrades binding performance #45968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
tanruian
changed the title
|
We might also be able to implement |
Update `ManagementContextAutoConfiguration`. use an EnumerablePropertySource to provide better property binding performance Signed-off-by: tanruian <tanruiantra@qq.com>
philwebb
added
type: bug
philwebb
changed the title
philwebb
pushed a commit
that referenced
this pull request
Jun 17, 2025
Update `ManagementContextAutoConfiguration` to use an immutable `EnumerablePropertySource` to provide better property binding performance. See gh-45968 Signed-off-by: tanruian <tanruiantra@qq.com>
philwebb
added a commit
that referenced
this pull request
Jun 17, 2025
|
Thanks very much @tanruian. I've made some changes for #45994 that should make these performance improvements less necessary. I still think they're worth fixing and I consider this a bug, but given it's less critical now the binder functionality has been restored, I'm only going to apply it to 3.5.x. Thanks again for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
ManagementContextAutoConfiguration. use an EnumerablePropertySource to provide better property binding performanceUpgrade spring-boot to 3.5.0, an issue where a property source binds to java objects slowly, for deep nested collection (consists of 4 depth), around 1 minutes. Number of scans of property with exponential growth.
Because the ManagementContextAutoConfiguration automatically adds an un enumerable property source to the environment，resulting in the inability to confirm whether the property source contains bindable property, requiring guessing and traversing property one by one based on the index 0-12
#45970