🔧(docker) add a service in compose to frontend development #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kharonus
reviewed
Jun 3, 2025
AntoLC
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
Pull Request Overview
Adds a new Docker Compose service for frontend development to enable hot reload by mounting local sources, and updates Makefile targets to use that service.
- Introduces
frontend-developmentservice in docker-compose with build args, volume mount, and port mapping - Updates Makefile
runalias to start the dev service instead of production frontend, and adjustsrun-frontend-developmentto stop containers before launching
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docker-compose.yml | Expose production frontend image/ports and add frontend-development service with build, volume, ports |
| Makefile | Change run to bring up frontend-development and update run-frontend-development stop logic |
Comments suppressed due to low confidence (2)
docker-compose.yml:174
- The
imagekey forfrontend-developmentis indented with 6 spaces, but service-level keys should use 4 spaces. This misalignment can cause a YAML parse error.
image: impress:frontend-development
Makefile:319
- The
run-frontend-developmenttarget stops both services but never starts thefrontend-developmentcontainer. To leverage the new Compose service for hot reload, add@$(COMPOSE) up --force-recreate -d frontend-developmentbefore runningyarn dev.
cd $(PATH_FRONT_IMPRESS) && yarn dev
lunika
force-pushed
the
feature/frontend-developement-container
branch
from
2a4510e to
118a5ae
Compare
lunika
force-pushed
the
feature/frontend-developement-container
branch
from
0adb6c0 to
ca7055d
Compare
We want a serice in compose starting the frontend application in development mode. We want to take the advantage of the hot reload module, so the sources are mounted inside the container.
`app` and `celery` services are not used when we run the compose configuration. The compose file is only used for development purpose.
To have a better developer experience, the y-provider service run in dev mode, allowing hot reload when a file is modified. To avoid issue with shared node_modules, they are mounted in a separated volume to not have then in the local directory.
The usage of docker-compose.yaml file is deprecated, we can rename it in compose.yml
We want to run the e2e tests using the frontend and y-provider production images. We created a dedicated compose file adding just missing services. These services are built in the CI.
lunika
force-pushed
the
feature/frontend-developement-container
branch
from
ca7055d to
35c7b9e
Compare
In order to speed the rebuild of images, the --no-cache option is removed by default. If we want to build the images without cache, the cache paramter must be used.
Without this, YdocConverter throws an error when developping.
lunika
force-pushed
the
feature/frontend-developement-container
branch
from
35c7b9e to
f97ab51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When a new user come on the project, clone it and run
make bootstrap, he is able to test the project but not starting directly to work on it, he also have to install all the frontend dependencies on its machine and then run the frontend application outside of the compose stack. Installing frontend dependencies is quite expensive and it has already made during the bootstrap but not reusable.We change the strategy in this PR, the
make bootstrapbuild all the images in frontend mode, there is no need anymore to re-install all frontend dependencies and run the frontend application outside the compose stack.The legacy behaviour is maintained, you can still run only the backend application with compose and the frontend using your local node installation.