json output install #392
Open
json output install #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roulpriya
requested review from
shahmishal,
cmcgee1024,
justice-adams-apple and
etcwilde
as code owners
roulpriya
force-pushed
the
json-output-install
branch
from
66d38b0 to
0a3c929
Compare
roulpriya
force-pushed
the
json-output-install
branch
from
0a3c929 to
6d83aef
Compare
cmcgee1024
reviewed
Jul 2, 2025
| if let progressFile | ||
| { | ||
| try JsonFileProgressReporter(ctx, filePath: progressFile) | ||
| } else if ctx.format == .json { |
There was a problem hiding this comment.
question: Since we've been generally putting messages on stderr when json formatted output is requested, could the ConsoleProgressReporter do the same thing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #376